guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: alacritty: Update to 0.7.1.


From: Nicolas Goaziou
Subject: Re: [PATCH] gnu: alacritty: Update to 0.7.1.
Date: Tue, 16 Feb 2021 21:38:52 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)

Hello,

Tobias Geerinckx-Rice <me@tobias.gr> writes:

> Commit 3e10f0eef0fb8b99f5220653b6564693365491b1 removes a phase:
>
>> Remove unneeded phase and some replacements.
>
> without explanation.  It's admittedly not the prettiest hack, but is
> needed to run Alacritty on Wayland[0].
>
> Do you remember why you removed it?  (Please, say so in the commit
> message!)

As written in the commit message, I removed it because Alacritty was
working without it here on my Gnome 3 Wayland session, hence the
"unneeded" part. What else was necessary?

Please bear in mind that:
1. it was not a small version bump, so many things could have changed in
   the package definition;

2. the hack is actually non-trivial as it references packages that do
   not even belong to the inputs but was not even a single comment line
   explaining its importance.

I'm sorry if you lost time re-instating this hack. OTOH, there is
certainly room for improvement in this situation.

Regards,
-- 
Nicolas Goaziou



reply via email to

[Prev in Thread] Current Thread [Next in Thread]