[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: 02/03: tests: gremlin: Skip file-needed/recursive if DT_NEEDED is em
From: |
Ludovic Courtès |
Subject: |
Re: 02/03: tests: gremlin: Skip file-needed/recursive if DT_NEEDED is empty. |
Date: |
Wed, 24 Feb 2021 11:20:34 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
guix-commits@gnu.org skribis:
> +++ b/tests/gremlin.scm
> @@ -61,7 +61,12 @@
> (elf-dynamic-info-needed dyninfo))))))
>
> (unless (and %guile-executable (not (getenv "LD_LIBRARY_PATH"))
> - (file-needed %guile-executable)) ;statically linked?
> + (file-needed %guile-executable) ;statically linked?
> + ;; When Guix has been built on a foreign distro, using a
> + ;; toolchain and libraries from that foreign distro, it is not
> + ;; unusual for the runpath to be empty.
> + (and=> (file-runpath %guile-executable)
> + (compose not null-list?)))
Nitpick: you can write ‘pair?’ instead of ‘(compose …)’.
I guess the problem is that ‘file-needed/recursive’ only looks at
RUNPATH, ignoring the notion of “standard directories” like /usr/lib.
Ludo’.
- Re: 02/03: tests: gremlin: Skip file-needed/recursive if DT_NEEDED is empty.,
Ludovic Courtès <=