guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Semi-automated patch review


From: Christopher Baines
Subject: Re: Semi-automated patch review
Date: Tue, 06 Apr 2021 08:43:38 +0100
User-agent: mu4e 1.4.15; emacs 27.1

Léo Le Bouter <lle-bout@zaclys.net> writes:

> Cbaines already runs automated patch testing infra at
> https://data.guix-patches.cbaines.net/ and
> https://patches.guix-patches.cbaines.net/project/guix-patches/list/
>
> Considering that posting robot messages with test/lint/+ result
> information on the issues directly and on the ML might get spammy, I
> suggest that Cbaines could setup something that sends off-list to all
> the participants or just the poster of the patch being tested, as well
> as another list like guix-ci-bot@cbaines.net that reviewers could
> voluntarily subscribe to to receive all those off-list messages.
>
> Another suggestion is that the infrastructure by Cbaines could include
> an easy way to lookup CI information from a bug id and that a link to
> see such CI information could be linked to from Mumi's
> (issues.gnu.guix.org) UI. But I also really think that mailing the
> contributors privately is very important so they can get automated
> feedback and save us time without any additional setup or knowledge
> required.
>
> What do you think?

So a technical component that I have in mind for this is supporting
subscriptions to data in the Guix Data Service, and that's something
that I'm hoping to at least start implementing in the coming weeks.

Once that's a possibility for the data relevant to patch series, I think
it will be feasible to look at having more useful "checks" in Patchwork
(e.g. broken builds, new lint warnings, ...) and perhaps sending emails
to the bug to set out that information.

There's also other related work still going on, I'm hoping to merge the
Laminar package and service soon [1] which I'm currently using for this
patch testing setup, and the upcoming Outreachy project on improving the
Guix Data Service performance will greatly benefit using the Guix Data
Service for patch review.

1: https://issues.guix.gnu.org/47392

Thanks,

Chris

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]