Re: Shepherd calendar event bug

[Ludovic Courtès]

Hi,

Felix Lechner <felix.lechner@lease-up.com> skribis:

> It would be the first Sunday in each month.

Oh right.  Now fixed!

  
https://git.savannah.gnu.org/cgit/shepherd.git/commit/?h=devel&id=71ef394a38f1d78eada901cb4c111c7b2be84ab5

(Along with related issues.)

> Also, here are some brief code questions, if you would be so kind to
> entertain them:
>
> Why are the ranges for minutes here [1] 0..60 instead of 0..59, and 0..7
> for days-of-week instead of 0..6, please? Even if the intervals were to
> exclude an end point [2] they seem inconsistent with 1..12 for the
> months or 1..31 for days-of-month.  Also, should the interval for the
> hours be 0..23 instead of 0..60?

> [1] 
> https://git.savannah.gnu.org/cgit/shepherd.git/tree/modules/shepherd/service/timer.scm?h=devel#n440

This code describes a count and a minimum value, rather than an actual
range: 60 minutes and starting from 0, 12 months and starting from 1,
etc.

Thanks for your feedback!

Ludo’.