guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Cookbook recipe from "The Repository as a Channel" section does not


From: pelzflorian (Florian Pelz)
Subject: Re: Cookbook recipe from "The Repository as a Channel" section does not work for Guix with properly configured GUILE_LOAD_PATH
Date: Mon, 26 Aug 2024 10:50:45 +0200
User-agent: Gnus/5.13 (Gnus v5.13)

Hello Nigko.

Nigko Yerden <nigko.yerden@gmail.com> writes:
> pelzflorian (Florian Pelz) wrote:
>> If the configuration or package file is not in the load-path,
>> guile-package.scm is returned, absolute-dirname’s other `if' branch
>> calls `canonicalize-path' on all but the basename and directory symlinks
>> already got resolved.
> No, in this case 'search-path' returns #f. But if 'syntax-source' gives
> absolute path, then 'current-source-directory' returns 'dirname' of this
> path without calling 'absolute-dirname'.

Oops.  Indeed, your view is right.

Still, when would your diff break someone else’s code?

They would need to currently use `local-file' or `current-source-directory'
to reference a file in .config/guix/current/share/guile/site/3.0,
which your diff would break.  But this still seems unlikely to me.

What `local-file' needs is a kind of current-source-directory.
Current `current-source-directory' does a bad job in channels.  Your
diff does fix this.  The compatibility burden is on the channel
authors.  `current-source-directory' would no longer be bad in what we
deem realistic use.

Regards,
Florian



reply via email to

[Prev in Thread] Current Thread [Next in Thread]