Re: Request for assistance maintaining LibreWolf

[Ludovic Courtès]

Hello,

André Batista <nandre@riseup.net> skribis:

>> Yes, it works whether or not one has commit rights, and I agree that it
>> could be helpful here.
>
> Should I send a patch adding myself to the team? What is expected from
> team members?

Yes, you can send a patch.

Team members are expected to coordinate and work together (e.g., for
review) on everything in the team’s scope, onboard new members willing
to help, and coordinate with the rest of the project.

(That <https://guix.gnu.org/manual/devel/en/html_node/Teams.html>
doesn’t even say this is something we should fix!)

>> Ian, what about teaming up with other Firefox derivative maintainers?
>> I’m thinking notably of André and Clément who’ve worked on Tor Browser
>> on Mullvad Browser, Mark H Weaver who’s been maintaining IceCat, and
>> perhaps Jonathan who’s been taking care of IceDove (Cc’d)?
>> 
>> Of course, each of these package is different but they’re in the same
>> area so it probably makes sense to share reviewing efforts here.
>
> I was reticent on this mainly because (i) I have never actually used
> LibreWolf and I don't have a clear picture of it besides it being a
> "Firefox + Arkenfox - Mozilla Branding" [1](?); (ii) I expect that most
> of these security (aka urgent) patches will land on the same day on a
> regular basis for all 4 browsers and given Mullvad and TorBrowser
> sources will be late in the game, I'll probably not be able to do such
> a timely (yet again, urgent) review, which could add to Ian's
> frustration, instead of relieving it; and (iii) AFAIUI, LibreWolf moves
> at a faster pace, which adds to my concern of not being able to keep up
> in the long run.
>
> That being said, given those patches have remained unreviewed for weeks
> in a row, I guess I can at least help improve the current situation and
> give commiters some more confidence that a given patch will not break
> hell loose when commited and so I'm willing to help with these reviews.
> However, I cannot promise to maintain it if/when Ian's lead happens to
> go missing.

Sure.  The goal is to create a group of people with similar interests
and a commitment to help together (of course team members can resign
anytime they feel they will no longer be able to honor that commitment).

Surely you’d do a better job at reviewing LibreWolf patches than myself,
say, thanks to the experience you have with Tor Browser.

> One question in that regard: is there any difference between reviewing
> through QA's web interface and sending mail commands to debbugs'
> control? Is any of them preferable? I'd rather use the mail interface if
> that's enough.

The interface at <https://qa.guix.gnu.org/patches> shows results from
automated builds, as an aid for reviewers.  The actual interface for
reviews remains email.

HTH!

Ludo’.