[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#26645: [PATCH 4/9] guix: Add "potluck" command.
From: |
Ludovic Courtès |
Subject: |
bug#26645: [PATCH 4/9] guix: Add "potluck" command. |
Date: |
Thu, 04 May 2017 22:23:34 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
Hello!
Andy Wingo <address@hidden> skribis:
> * guix/scripts/potluck.scm: New file.
> * Makefile.am: Add new file.
[...]
> + (call-with-output-file (in-vicinity potluck-dir "README.md")
> + (lambda (port)
> + (format port
> + "\
Please add (G_ …) for i18n, and also add the file to po/guix/POTFILES.in.
> +This directory defines potluck packages. Each file in this directory should
> +define one package. See https://potluck.guixsd.org/ for more information.
I’ll email guix-sysadmin so potluck.guixsd.org points to the same IP as
guix-potluck.org. :-)
> + (let* ((opts (parse-command-line args %options
> + (list %default-options)
> + #:argument-handler
> + parse-sub-command))
‘parse-command-line’ honors $GUIX_BUILD_OPTIONS, which is unnecessary
here. Instead, we should use ‘args-fold*’ like in (guix scripts hash),
for instance.
Otherwise LGTM, thanks!
Ludo’.
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- bug#26645: [PATCH 4/9] guix: Add "potluck" command.,
Ludovic Courtès <=