[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#26840: [PATCH 2/3] gnu: go-1.4: Add missing module imports.
From: |
Kei Kebreau |
Subject: |
bug#26840: [PATCH 2/3] gnu: go-1.4: Add missing module imports. |
Date: |
Fri, 12 May 2017 19:05:22 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
address@hidden (Ludovic Courtès) writes:
> Hi Kei,
>
> Kei Kebreau <address@hidden> skribis:
>
>> Sergei Trofimovich <address@hidden> writes:
>>
>>> * gnu/packages/golang.scm (go-1.4): Add missing modules to
>>> %modify-phases call: srfi-1
>>> ---
>>> gnu/packages/golang.scm | 3 ++-
>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
>>> index 00630ce06..d19aa65af 100644
>>> --- a/gnu/packages/golang.scm
>>> +++ b/gnu/packages/golang.scm
>>> @@ -62,7 +62,8 @@
>>> (arguments
>>> `(#:modules ((ice-9 match)
>>> (guix build gnu-build-system)
>>> - (guix build utils))
>>> + (guix build utils)
>>> + (srfi srfi-1))
>>> #:tests? #f ; Tests are run by the all.bash script.
>>> #:phases
>>> (modify-phases %standard-phases
>>
>> */me looks at git log and facepalms*
>>
>> Never mind my other email... I see that the reason these are already on
>> master is because they were already pushed there. Feel free to close
>> these!
>
> Though as discussed in another thread with Sergei, it’s not entirely
> clear to me that these #:modules patches should be committed (and they
> are for ‘core-updates’, not ‘master’.)
>
> I would rather see whether we can find a more generic solution to this
> problem before patching every single instance.
>
> How does that sound?
>
> Ludo’.
I have no objections. Should the patches already on master be reverted,
or should they be left until further notice?
signature.asc
Description: PGP signature
- bug#26841: [PATCH 0/3] core-updates: more fixes for missing dependencies for %modify-phases, Sergei Trofimovich, 2017/05/08
- bug#26840: [PATCH 2/3] gnu: go-1.4: Add missing module imports., Sergei Trofimovich, 2017/05/08
- bug#26840: [PATCH 2/3] gnu: go-1.4: Add missing module imports., Kei Kebreau, 2017/05/11
- bug#26840: [PATCH 2/3] gnu: go-1.4: Add missing module imports., Danny Milosavljevic, 2017/05/11
- bug#26840: [PATCH 2/3] gnu: go-1.4: Add missing module imports., Kei Kebreau, 2017/05/11
- bug#26840: [PATCH 2/3] gnu: go-1.4: Add missing module imports., Leo Famulari, 2017/05/11
- bug#26840: [PATCH 2/3] gnu: go-1.4: Add missing module imports., Marius Bakke, 2017/05/11
- bug#26840: [PATCH 2/3] gnu: go-1.4: Add missing module imports., Danny Milosavljevic, 2017/05/11
- bug#26840: [PATCH 2/3] gnu: go-1.4: Add missing module imports., Leo Famulari, 2017/05/12
- bug#26840: [PATCH 2/3] gnu: go-1.4: Add missing module imports., Ludovic Courtès, 2017/05/12
- bug#26840: [PATCH 2/3] gnu: go-1.4: Add missing module imports.,
Kei Kebreau <=
- bug#26840: [PATCH 2/3] gnu: go-1.4: Add missing module imports., Ludovic Courtès, 2017/05/13
bug#26842: [PATCH 1/3] gnu: zip: add missing '#:modules' imports, Sergei Trofimovich, 2017/05/08
bug#26843: [PATCH 3/3] gnu: sbcl: Add missing module imports, Sergei Trofimovich, 2017/05/08
bug#26841: [PATCH 0/3] core-updates: more fixes for missing dependencies for %modify-phases, Danny Milosavljevic, 2017/05/09