[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#30744] [PATCH] tests: mail: Add test for dovecot.
From: |
Oleg Pykhalov |
Subject: |
[bug#30744] [PATCH] tests: mail: Add test for dovecot. |
Date: |
Fri, 09 Mar 2018 12:31:38 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) |
Hello Clément,
Clément Lassieur <address@hidden> writes:
> Oleg Pykhalov <address@hidden> writes:
[…]
>> + ;; Give the service time to start talking.
>> + (wait-for-file "/var/run/dovecot/master.pid" marionette)
>
> Could you put it in a test context (test-assert with file-exists? for
> example, see tests/messaging.scm)?
OK.
I replaced ‘(wait-for-file …)’ and a comment with:
--8<---------------cut here---------------start------------->8---
;; Check Dovecot service's PID.
(test-assert "service process id"
(let ((pid
(number->string (wait-for-file "/var/run/dovecot/master.pid"
marionette))))
(marionette-eval `(file-exists? (string-append "/proc/" ,pid))
marionette)))
--8<---------------cut here---------------end--------------->8---
[…]
>> + (match (scandir TESTBOX/new)
>> + ((cwd .. message-file)
>
> You need to use double quotes, like ("." ".." message-file) I believe.
It works. Thank you!
[…]
I think it's ready for a push to ‘origin/master’. WDYT?
Oleg.
signature.asc
Description: PGP signature
- [bug#30744] [PATCH 1/2] services: dovecot: Copy dovecot.conf to /etc/dovecot., Oleg Pykhalov, 2018/03/07
- [bug#30744] [PATCH] tests: mail: Add test for dovecot., Oleg Pykhalov, 2018/03/07
- [bug#30744] [PATCH] tests: mail: Add test for dovecot., Clément Lassieur, 2018/03/07
- [bug#30744] [PATCH] tests: mail: Add test for dovecot., Oleg Pykhalov, 2018/03/08
- [bug#30744] [PATCH] tests: mail: Add test for dovecot., Oleg Pykhalov, 2018/03/08
- [bug#30744] [PATCH] tests: mail: Add test for dovecot., Clément Lassieur, 2018/03/08
- [bug#30744] [PATCH] tests: mail: Add test for dovecot.,
Oleg Pykhalov <=
- [bug#30744] [PATCH] tests: mail: Add test for dovecot., Clément Lassieur, 2018/03/09
- [bug#30744] [PATCH] tests: mail: Add test for dovecot., Oleg Pykhalov, 2018/03/09
[bug#30744] [PATCH 1/2] services: dovecot: Copy dovecot.conf to /etc/dovecot., Clément Lassieur, 2018/03/07