[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#34040] [PATCH 1/2] refresh: Suggest input changes when updating.
From: |
Ludovic Courtès |
Subject: |
[bug#34040] [PATCH 1/2] refresh: Suggest input changes when updating. |
Date: |
Sat, 12 Jan 2019 14:40:47 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Hello,
Ricardo Wurmus <address@hidden> skribis:
> * guix/upstream.scm (<upstream-source>)[input-changes]: New field.
> (<upstream-input-change>): New record.
> (upstream-input-change?, upstream-input-change-name,
> upstream-input-change-type, upstream-input-change-action, changed-inputs): New
> procedures.
> (package-update): Pass along input changes.
> * guix/script/refresh.scm (update-package): Process input changes.
Really cool!
> +;; Representation of an upstream input change.
> +(define-record-type* <upstream-input-change>
> + upstream-input-change make-upstream-input-change
> + upstream-input-change?
> + (name upstream-input-change-name) ;string
> + (type upstream-input-change-type) ;symbol: regular | native |
> propagated
> + (action upstream-input-change-action)) ;symbol: add | remove
Perhaps in some cases in action could be, say, (upgrade "1.2"). Though
that’s of course something we can add later.
> (define* (package-update store package updaters
> #:key (key-download 'interactive))
> - "Return the new version and the file name of the new version tarball for
> -PACKAGE, or #f and #f when PACKAGE is up-to-date. KEY-DOWNLOAD specifies a
> -download policy for missing OpenPGP keys; allowed values: 'always', 'never',
> -and 'interactive' (default)."
> + "Return the new version, the file name of the new version tarball and input
^
Missing comma. :-)
> +changes for PACKAGE, or #f and #f when PACKAGE is up-to-date. KEY-DOWNLOAD
^
Instead of “, or …”:
; return #f (three values) when PACKAGE is up-to-date.
Otherwise LGTM, thanks!
Ludo’.