[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#35895] [PATCH] linux-container: Remove networking service when netw
From: |
Danny Milosavljevic |
Subject: |
[bug#35895] [PATCH] linux-container: Remove networking service when network is shared with host. |
Date: |
Mon, 3 Jun 2019 19:11:36 +0200 |
On Sat, 25 May 2019 13:37:51 +0100
Christopher Baines <address@hidden> wrote:
> Arun Isaac <address@hidden> writes:
>
> > * gnu/system/linux-container.scm (dummy-networking-shepherd-service): New
> > procedure.
> > (dummy-networking-service-type): New variable.
> > (containerized-operating-system): If network is shared with host, replace
> > static-networking-service-type with dummy-networking-service-type.
>
> Sounds good. It would be good to have the motivation/reasoning behind
> this change in the commit message though.
IMO in a comment, not in a commit message :)
Let's not make commit messages the documentation--except when it's impossible
to document otherwise.
In this case it's pretty clear what the form in containerized-operating-system
does, but yeah, maybe a comment like the following:
;; Many Guix services (which?) depend on a 'networking' shepherd service, so
;; make sure to provide a dummy 'networking' service when we are sure that
;; networking is already set up in the host and can be used.
;; That prevents double-setup.
pgpna7CWbMh7l.pgp
Description: OpenPGP digital signature
- [bug#35895] [PATCH] linux-container: Remove networking service when network is shared with host.,
Danny Milosavljevic <=