[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#39547] [PATCH v3] sources.json: array instead of list
From: |
Ludovic Courtès |
Subject: |
[bug#39547] [PATCH v3] sources.json: array instead of list |
Date: |
Fri, 06 Mar 2020 12:01:36 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Hi!
zimoun <address@hidden> skribis:
> Attached, the tiny modification to output the list (array) of URLs
> instead of the first one.
> The version number is still '1' because I do not know yet if lewo would bump
> it.
> Note also that "transformer" is not useful any more because
> 'packages-json-builder' and 'sources-json-builder' returns both
> vectors now.
Cool.
> From 57a444f6f215fb6327719161a6e6ad4ad229273f Mon Sep 17 00:00:00 2001
> From: zimoun <address@hidden>
> Date: Mon, 10 Feb 2020 17:52:13 +0100
> Subject: [PATCH v3 1/2] website: Refactor and resolve mirror:// of JSON
> package list.
>
> * website/apps/packages/builder.scm (origin->json): New procedure.
LGTM!
> From 73557bc00760b4404bfe17ecb3aca983c6dcc11e Mon Sep 17 00:00:00 2001
> From: zimoun <address@hidden>
> Date: Tue, 18 Feb 2020 13:25:14 +0100
> Subject: [PATCH v3 2/2] website: Provide JSON sources list used by Software
> Heritage.
>
> Format discussed here <https://forge.softwareheritage.org/D2025#51269>.
>
> * website/apps/packages/builder.scm (origin->json): Add list modifier.
> * website/apps/packages/builder.scm (sources-json-builder): New procedure.
Nitpick: no need to repeat the file name here.
Also: please mention the addition to the ‘builder’ procedure.
> +(define* (origin->json origin #:optional (transformer list->vector))
You can remove this parameter, as you wrote.
I can make these changes and push it on your behalf if you want, let me
know!
Thanks,
Ludo’.