[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#42634] [PATCH 3/3] scripts: system: Add support for image-type.
From: |
Ludovic Courtès |
Subject: |
[bug#42634] [PATCH 3/3] scripts: system: Add support for image-type. |
Date: |
Thu, 24 Sep 2020 17:39:33 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Mathieu Othacehe <m.othacehe@gmail.com> skribis:
> * guix/scripts/system.scm (list-image-types): New procedure,
> (%options): add "image-type" and "list-image-types" options, remove
> "file-system-type" option,
> (show-help): adapt accordingly,
> (%default-options): also adapt, and set the default "image-type" to "raw",
> (perform-action): add image-type argument and remove file-system-type
> argument,
> (process-action): adapt perform-action call,
> (system-derivation-for-action): remove base-image
> argument, add image-type argument, and use it to create the image passed to
> "system-image".
LGTM (with corresponding doc)!
Perhaps you can also add a ‘guix system list-image-types’ command to
tests/guix-system.sh for good measure. That’d at least catch broken
modules and similar.
Thanks,
Ludo’.
- [bug#42634] [PATCH 3/3] scripts: system: Add support for image-type.,
Ludovic Courtès <=