[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#47608] adds emacs-lockstep
From: |
Nicolas Goaziou |
Subject: |
[bug#47608] adds emacs-lockstep |
Date: |
Sun, 11 Apr 2021 11:00:32 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Hello,
rdes via Guix-patches via <guix-patches@gnu.org> writes:
> The attached patch adds emacs-lockstep.
Thank you. Some comments follow.
> +(define-public emacs-lockstep
> + (let ((commit "5fe78e94533c4a050d3fce23685040ac754c2e54"))
A comment should explain why we're using a commit hash instead of a tag.
> + (package
> + (name "emacs-lockstep")
> + (version "0.1")
This is not the correct version. Actually, I couldn't find any reference
to a version at all in the file, so it should be "0", with a comment.
> + (synopsis
> + "Pair program in Emacs")
Nitpick: Pair programming in Emacs
> + (description
> + "Lockstep is a package for pair programming in Emacs. It synchronizes
> +the windows and points of two or more Emacs frames, so that a team of
> +programmers can share an editing session.
> +
> +BE CAREFUL: any programmer in the session will be able to control the Emacs
> +process running as the user who started the Emacs server.")
Nitpick:
Be careful! All programmers see the same buffers and live edits, and
any programmer can take over the editing session.
> + (license license:gpl3+))))
Unfortunately, I see no reference whatsoever to a license in the code
base. I don't think we can infer this is GPL3+. What makes you think so?
Regards,
--
Nicolas Goaziou