[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#48028] [PATCH wip-gnome 5/8] gnu: libsoup: Add missing argument and
From: |
Leo Prikler |
Subject: |
[bug#48028] [PATCH wip-gnome 5/8] gnu: libsoup: Add missing argument and input. |
Date: |
Mon, 26 Apr 2021 11:47:15 +0200 |
User-agent: |
Evolution 3.34.2 |
Am Montag, den 26.04.2021, 05:28 -0400 schrieb Raghav Gururajan:
> Hi Leo!
>
> > This looks like it could be its own patch were it not for the fact,
> > that samba needs to be added as well (what for?)
>
> I have split them into two patches and added comment, in v3.
>
> > That doesn't sound very sure to me. Why are you wrapping binaries
> > and/or compiling schemas?
>
> It is mainly for compiling schemas, as libsoup doesn't have binaries
> to
> wrap. But I just now realized that there is no
> `[out]/share/glib-2.0/schemas` either. So I removed this in v3.
>
> > Careful with the indentation.
>
> Ah, good catch. I have fixed it in v3.
v3 06/07 LGTM, but could in my opinon be merged into a single patch
with the line: "gnu: libsoup: Add missing inputs." or perhaps "gnu:
libsoup: Adjust inputs". I've CC'd Mark Weaver to hear their input.
Regards,
Leo
- [bug#48028] [PATCH wip-gnome 7/8] gnu: python-pycairo: Update to 1.20.0., (continued)
- [bug#48028] [PATCH wip-gnome 8/8] gnu: python-pygobject: Update to 3.40.1., Raghav Gururajan, 2021/04/26
- [bug#48028] [PATCH wip-gnome 5/8] gnu: libsoup: Add missing argument and input., Raghav Gururajan, 2021/04/26
- [bug#48028] [PATCH wip-gnome 5/8] gnu: libsoup: Add missing argument and input., Leo Prikler, 2021/04/26
- [bug#48028] [PATCH wip-gnome 5/8] gnu: libsoup: Add missing argument and input., Raghav Gururajan, 2021/04/26
- [bug#48028] [PATCH wip-gnome 5/8] gnu: libsoup: Add missing argument and input.,
Leo Prikler <=
- [bug#48028] [PATCH wip-gnome 5/8] gnu: libsoup: Add missing argument and input., Raghav Gururajan, 2021/04/26
- [bug#48028] [PATCH wip-gnome v4 3/8] gnu: gtkmm: Add missing native-input and correct propagated-inputs, Mark H Weaver, 2021/04/26
- [bug#48028] [PATCH wip-gnome v4 3/8] gnu: gtkmm: Add missing native-input and correct propagated-inputs, Raghav Gururajan, 2021/04/27
- [bug#48028] [PATCH wip-gnome v4 3/8] gnu: gtkmm: Add missing native-input and correct propagated-inputs, Mark H Weaver, 2021/04/27
[bug#48028] [PATCH wip-gnome 1/8] gnu: gtkmm@2: Remove inheritance from gtkmm@3., Maxime Devos, 2021/04/26
[bug#48028] [PATCH wip-gnome v2 01/10] gnu: gtkmm@2: Remove inheritance from gtkmm@3., Raghav Gururajan, 2021/04/26