[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#63403] [PATCH 1/1] services: wireguard: Implement a dynamic IP moni
From: |
Ludovic Courtès |
Subject: |
[bug#63403] [PATCH 1/1] services: wireguard: Implement a dynamic IP monitoring feature. |
Date: |
Wed, 24 May 2023 16:44:40 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Hi Maxim,
Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
> Ludovic Courtès <ludo@gnu.org> writes:
>
>> Hi,
>>
>> Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
>>
>>> * gnu/services/herd.scm (current-service): New procedure, mostly reusing the
>>> existing current-services.
>>> (current-services): Implement in terms of the above procedure.
>>
>> How about having (lookup-service name) that calls the ‘status’ action on
>> the given service and either returns a <live-service> or #f?
>
> I'd rather keep the name 'current-service',
There’s no notion of a “current service” in the Shepherd; that would be
confusing to me.
> because 'lookup-service' is already a public procedure exported by
> Shepherd's (shepherd service) module; it'd be confusing.
Yeah well, I think we should clarify the client/server architecture and
the context in which (shepherd …) modules are meant to be used. I made
a first attempt:
https://git.savannah.gnu.org/cgit/shepherd.git/commit/?id=d3d437a34bcb11fc416bf141181d8908064aeceb
However, what matters most to me is that the procedure names really
represent what they do. With that in mind, it’s no surprise that the
procedure to look up a service is called ‘lookup-service’ in both
contexts.
Thanks,
Ludo’.
- [bug#63402] [PATCH v3 3/3] services: wireguard: Workaround keep-alives bug., (continued)
- [bug#63402] [PATCH v5 2/5] services: wireguard: Implement a dynamic IP monitoring feature., Maxim Cournoyer, 2023/05/18
- [bug#63403] [PATCH 1/1] services: wireguard: Implement a dynamic IP monitoring feature., Ludovic Courtès, 2023/05/22
- [bug#63402] bug#63403: [PATCH 1/1] services: wireguard: Implement a dynamic IP monitoring feature., Maxim Cournoyer, 2023/05/22
- [bug#63403] [PATCH 1/1] services: wireguard: Implement a dynamic IP monitoring feature., Ludovic Courtès, 2023/05/24
- [bug#63403] [PATCH 1/1] services: wireguard: Implement a dynamic IP monitoring feature., Bruno Victal, 2023/05/24
- [bug#63402] bug#63403: [PATCH 1/1] services: wireguard: Implement a dynamic IP monitoring feature., Maxim Cournoyer, 2023/05/25
- [bug#63402] [PATCH v5 2/5] services: wireguard: Implement a dynamic IP monitoring feature., Bruno Victal, 2023/05/24
[bug#63402] [PATCH v5 3/5] services: wireguard: Clean-up configuration file serializer., Maxim Cournoyer, 2023/05/18
[bug#63402] [PATCH v5 4/5] services: wireguard: Add a 'configuration' action., Maxim Cournoyer, 2023/05/18
[bug#63402] [PATCH v5 5/5] gnu: linux-libre: Apply wireguard patch fixing keep-alive bug., Maxim Cournoyer, 2023/05/18