guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#63897] [PATCH v6] gnu: tensorflow-lite: Update to 2.12.1


From: Ricardo Wurmus
Subject: [bug#63897] [PATCH v6] gnu: tensorflow-lite: Update to 2.12.1
Date: Tue, 05 Sep 2023 09:50:31 +0200
User-agent: mu4e 1.10.5; emacs 28.2

Hi,

The update looks good to me.  My only concerns are cosmetic:

- the indentation throughout is rather wonky.  Would be good to reformat
  this with Emacs C-M-q or “guix style”.

- “TO DO” —> “TODO” (so we can find it easily)

- please use “;;” for line comments; a single semicolon is only used for
  margin comments

- it would be good not to use “assoc-ref %build-inputs” and use G-exps
  instead.

I could make all these changes before pushing it.

Actually, there is one question I have that is not of cosmetic nature:
What’s up with the commented gemmlowp in the inputs?  We have
gemmlowp-src in the native-inputs.

If you could answer this question I can take care of the rest and apply
it.  Thank you for your patience!

-- 
Ricardo





reply via email to

[Prev in Thread] Current Thread [Next in Thread]