[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#66034] [PATCH gnome-team 1/3] gnu: glib: fix required.private refer
From: |
Liliana Marie Prikler |
Subject: |
[bug#66034] [PATCH gnome-team 1/3] gnu: glib: fix required.private reference to pcre. |
Date: |
Sat, 16 Sep 2023 20:52:11 +0200 |
User-agent: |
Evolution 3.46.4 |
Am Samstag, dem 16.09.2023 um 11:55 +0200 schrieb Vivien Kraus:
> * gnu/packages/glib.scm (glib) [#:phases 'patch-pkg-config-files]:
> Replace the reference to libpcre-8 to libpcre2-8.
> ---
Logic-wise LGTM, but…
> gnu/packages/glib.scm | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/glib.scm b/gnu/packages/glib.scm
> index 8af89d60e0..dcc61802a4 100644
> --- a/gnu/packages/glib.scm
> +++ b/gnu/packages/glib.scm
> @@ -449,7 +449,12 @@ (define glib
> (("^bindir=.*")
> "")
> (("=\\$\\{bindir\\}/")
> - "=")))))))
> + "="))
> + ;; Update the required.private pcre pkg-config name
> + (substitute*
> + (list (search-input-file outputs
> "lib/pkgconfig/glib-2.0.pc"))
Is there a reason to use a list here? Also, can we not do this
earlier?
> + (("libpcre-8")
> + "libpcre2-8")))))))
This fits in one line.
Cheers