Re: [Gzz] PEG ``vob_colorable--humppake``: Abstract Colorable Vob

[Asko Soukka]

Tue, 11 Mar 2003, Tuomas Lukka wrote:
> > > > > >     class Colorable "interface"
> > > > > >         methods
> > > > > >         +Colorable cloneColored(List colors)
> > > > > >         +List getColors()
> > > > > Now that it's immutable, I'm actually leaning slightly towards 
> > > > > Color[] 
> > > > > colors...
> > > The reason is performance: arrays perform much better than lists, 
> > > especially
> > > in kaffe where garbage collection is relatively inefficient.
> > Well, using Color[] implies additional parameter to provide the amount of 
> > colors in that array.
> I think first null would be ok.

Good, this keeps the interface simple...

> > Should we now add to AbstractColorableVob a static help function to help 
> > handling Color[]?
> I don't really like this; it doesn't belong there. If you want to use a list
> when building it up, you can and call list.toArray

...and if this won't harm the performance there shouldn't even be nulls at 
the end of arrays.

-- 
Asko Soukka <address@hidden>
<http://www.iki.fi/asko.soukka/>