|
From: | Benja Fallenstein |
Subject: | [Fwd: Re: [Gzz] PEG Colorable Vob] |
Date: | Wed, 12 Mar 2003 18:54:56 +0100 |
User-agent: | Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2.1) Gecko/20021226 Debian/1.2.1-9 |
(wrong reply button)
--- Begin Message ---Subject: Re: [Gzz] PEG Colorable Vob Date: Wed, 12 Mar 2003 18:54:05 +0100 User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2.1) Gecko/20021226 Debian/1.2.1-9 Tuomas Lukka wrote:On Wed, Mar 12, 2003 at 11:58:43AM +0200, Asko Soukka wrote:Should Colorable.cloneColored() return itself, if attribute colors is empty or null? It would make the previous example cleaner - no ifs would be needed anymore:Color[] colors = (Color[]) vobColors.toArray(new Color[1]); bg = (ColorableVob)defaultBg.cloneColored(colors);Absolutely not. It should return itself, if 1) parameter colors is empty or null ***AND*** 2) its own colors are empty or null. It is *allowed* to return itself also, if parameter colors == its own colors, but not obligated to compare the lists.Is cloneColored supposed to remove the colors which are already there?!? I find that counter-intuitive.-b
--- End Message ---
[Prev in Thread] | Current Thread | [Next in Thread] |