Re: problem parsing EHLO in src/smtp.c for version 2.1.0

[Manvendra Bhangui]

I found an issue with my patch when the AUTH capability was actually
the last capability. So the current patch attached works only if the
AUTH capability is not the last capability

On Mon, 15 Aug 2022 at 23:59, Manvendra Bhangui <mbhangui@gmail.com> wrote:
>
> I have discovered one issue with gsasl-2.1.0 in src/smtp.c. The issue happens 
> when the response to EHLO that has capabilities other than AUTH after the 
> AUTH capability. e.g.
>
> $ telnet 0 2000
> Trying 0.0.0.0...
> Connected to 0.
> Escape character is '^]'.
> 220 indimail.org (NO UCE) ESMTP IndiMail 1.260 Mon, 15 Aug 2022 23:48:13 +0530
> ehlo
> 250-indimail.org [::ffff:127.0.0.1]
> 250-AUTH CRAM-MD5 CRAM-SHA1 CRAM-SHA224 CRAM-SHA256 CRAM-SHA384 CRAM-SHA512 
> CRAM-RIPEMD DIGEST-MD5 SCRAM-SHA-1 SCRAM-SHA-1-PLUS SCRAM-SHA-256 
> SCRAM-SHA-256-PLUS
> 250-PIPELINING
> 250-8BITMIME
> 250-SIZE 10000000
> 250-ETRN
> 250-STARTTLS
> 250 HELP
>
> The earlier versions didn't have problems parsing this. I'm including a patch 
> attached with this email that fixes the parsing problem when the 250-AUTH is 
> not the last capability.
>
> --
> Regards Manvendra - http://www.indimail.org
> GPG Pub Key
> http://pgp.mit.edu:11371/pks/lookup?op=get&search=0xC7CBC760014D250C



-- 
Regards Manvendra - http://www.indimail.org
GPG Pub Key
http://pgp.mit.edu:11371/pks/lookup?op=get&search=0xC7CBC760014D250C

gsasl-2.1.0-smtp.patch
Description: Binary data