help-guix
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Guix Days: Patch flow discussion


From: Steve George
Subject: Re: Guix Days: Patch flow discussion
Date: Mon, 5 Feb 2024 22:10:12 +0000
User-agent: Mozilla Thunderbird

On 05/02/2024 15:57, Clément Lassieur wrote:
Hello,

On Mon, Feb 05 2024, Steve George wrote:

Hi,

Our goal for the discussion:

        How do we double the number of patches that are *reviewed* and
        *applied* to Guix in the next six months?

Patch flow is a pipeline, to change it we could:

a. Increase the number of committers - more people to do the
work

I don't think reviewers have to be committers.  If a patch is marked as
‘reviewed’ by a non-commiter, another person can just apply the patch
and push.  Although the commiter will take some responsibility in doing
so, and make sure the review was done correctly, it still makes their
work way easier.

My point is that not being committer shouldn't discourage people to
review patches.
(...)

Agreed - I put it a bit lower in the notes - clearly managed to bury it :-)

The discussion focused on increasing the number of Reviewers. A reviewer can be anyone - they don't need to be a committer.

The purpose of the proposed 'Patch Review' sessions is for contributors to come along and review patches together.

Thanks,

Steve





reply via email to

[Prev in Thread] Current Thread [Next in Thread]