help-smalltalk
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Help-smalltalk] Version number in star packages


From: Gwenael Casaccio
Subject: Re: [Help-smalltalk] Version number in star packages
Date: Thu, 31 Dec 2009 13:09:57 +0100

On Thu, 2009-12-31 at 00:55 +0100, Paolo Bonzini wrote:
> On 12/30/2009 11:15 PM, Gwenael Casaccio wrote:
> > +    parseVersion: aString [
> > +   <category: 'version parsing'>
> > +
> > +   | tokens |
> > +   (tokens := aString tokenize: '\.') size = 3 ifFalse: [ self error: 'Bad 
> > version string : ', aString, ' should be xx.yy.zz' ].
> > +   self version: (Version major: tokens first asInteger minor: tokens 
> > second asInteger patch: tokens third asInteger)
> > +    ]
> 
> This should:
> 
> 1) use #subStrings: or alternatively a single regex match
> 
>      ^(\d+)\.(\d+)(?:\.(\d+))$
> 
> instead of tokenize.
> 
> 2) be in Version class>>#fromString:
> 
> 3) accept a version like 1.0 and change it to 1.0.0 (see regex above).
> 
> Otherwise looks fine, filtering of prerequisites based on their version 
> can be done later.
> 
> Paolo

Hi,

Here are the changes.

Cheers,
Gwen

Attachment: version.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]