help-smalltalk
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Help-smalltalk] [RFC PATCH 0/2] fix overflow check for #basicAt: and #b


From: Paolo Bonzini
Subject: [Help-smalltalk] [RFC PATCH 0/2] fix overflow check for #basicAt: and #basicAt:put:
Date: Thu, 27 Jun 2013 11:56:36 +0200

Holger found an overflow bug in #basicAt: and #basicAt:put:,
which breaks classes that have both fixed and indexed instance
variables.  The following patches fix it; I didn't yet add
testcases or attempted to deal with the fallout: as expected,
the delays.st test starts failing as it does under the JIT.
DebugTools also fails due to the same access with index -1.

Paolo

Paolo Bonzini (2):
  tweak index_oop_spec and index_oop_put_spec index computations
  fix overflow check for #basicAt: and #basicAt:put:

 libgst/ChangeLog | 15 +++++++++++++++
 libgst/dict.inl  | 44 ++++++++++++++++++++++++--------------------
 2 files changed, 39 insertions(+), 20 deletions(-)

-- 
1.8.2.1




reply via email to

[Prev in Thread] Current Thread [Next in Thread]