[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Maybe a bug after df89d6d6dc429e638e425536d1c201b5373f2abd
From: |
Adam Sjøgren |
Subject: |
Re: Maybe a bug after df89d6d6dc429e638e425536d1c201b5373f2abd |
Date: |
Sat, 28 Dec 2019 02:17:22 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Lars writes:
> Garjola Dindi <garjola@garjola.net> writes:
>
>> I have a strange behaviour with recent versions of gnus (in emacs
>> master and branch emacs-27).
>>
>> When I try to subscribe to a group in the *Browse server buffer*, all
>> groups appear with the ’K’ mark and the subscribe command ’u’ does not
>> subscribe (the ’K’ still appears and the group is not subscribed).
>
> This was due to a recent change -- whenever a group changed level, it
> would put a nil onto gnus-newsrc-alist, thereby making it invalid.
>
> I've now pushed a fix for this to both emacs-27 and the trunk.
Is this a fix for:
7b3b27eef1325b41187f2e9cc898644d5eae9ff3 is the first bad commit
commit 7b3b27eef1325b41187f2e9cc898644d5eae9ff3
Author: Stefan Monnier <monnier@iro.umontreal.ca>
Date: Sun Dec 22 16:09:31 2019 -0500
* lisp/gnus/gnus-start.el: Use lexical-binding
(gnus-group-change-level, gnus-make-hashtable-from-newsrc-alist):
Use gnus-info-make.
(gnus-make-hashtable-from-newsrc-alist): Prefer `gnus-info-group`
to `car` when applied to a `gnus-info` object.
(gnus-make-hashtable-from-killed): Remove unused vars `lists` and `list`.
(gnus-gnus-to-quick-newsrc-format): Extract common code from if branches.
* lisp/gnus/gnus.el (gnus-info-make): New constructor.
lisp/gnus/gnus-start.el | 59
++++++++++++++++++++++---------------------------
lisp/gnus/gnus.el | 4 ++++
2 files changed, 31 insertions(+), 32 deletions(-)
?
I just bisected the problem that Garjola and I have hit, where if you
press u on an unsubscribed group, you get an error, and when quitting
Gnus you get something like this (with toggle-debug-on-error):
Debugger entered--Lisp error: (wrong-type-argument stringp nil)
encode-coding-string(nil utf-8-emacs)
#f(compiled-function (info) #<bytecode 0x1564b3c89a85>)(nil)
mapcar(#f(compiled-function (info) #<bytecode 0x1564b3c89a85>) (nil
("nntp+fb:feedbase.blog.adafruit.q..." [...cut...] ...))
gnus-gnus-to-quick-newsrc-format()
gnus-save-newsrc-file()
gnus-group-exit()
funcall-interactively(gnus-group-exit)
call-interactively(gnus-group-exit nil nil)
command-execute(gnus-group-exit)
and when quitting Emacs, it asks if .newsrc.eld should be saved (which
will save an almost empty file).
Best regards,
Adam
--
"It's a shite state of affairs to be in, and no Adam Sjøgren
amount of fresh air is ever going to change that." asjo@koldfront.dk