jami
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re patch set 27205 (CMakeLists.txt: use system <md4c, tidy>)


From: Maxim Cournoyer
Subject: Re patch set 27205 (CMakeLists.txt: use system <md4c, tidy>)
Date: Wed, 27 Mar 2024 12:32:17 -0400

Hi Adrien,

I do not understand why 'find_package' would fail as you wrote in [0].
The CMake documention says this about it:

--8<---------------cut here---------------start------------->8---
If any of these components are not able to be
satisfied, the package overall is considered to be not found.  If the
‘REQUIRED’ option is also present, this is treated as a fatal error,
otherwise execution still continues.
--8<---------------cut here---------------end--------------->8---

Since the 'find_package(md4c)' call lacks the REQUIRED argument, not
finding md4c from the environment should not be fatal.

[0] https://review.jami.net/c/jami-client-qt/+/27205/2/CMakeLists.txt#548

-- 
Thanks,
Maxim



reply via email to

[Prev in Thread] Current Thread [Next in Thread]