Re: [Jessie-discuss] unknown protocol name: SSLv2Hello

[chinmaya]

I tried patching ProtocolVersion.java manually, but when I did
I still get no response on browser, and no exceptions either on server side,
donno what is happening !! Any clues??

thanks
chinmaya


diff -c ProtocolVersion.java.bak ProtocolVersion.java

*** ProtocolVersion.java.bak    2007-04-05 13:42:12.000000000 -0600
--- ProtocolVersion.java        2007-04-05 15:23:
50.000000000 -0600
***************

*** 52,57 ****
--- 52,58 ----

    public static final ProtocolVersion SSL_3 = new ProtocolVersion(3, 0);
    public static final ProtocolVersion TLS_1 = new ProtocolVersion(3, 1);
    public static final ProtocolVersion TLS_1_1 = new ProtocolVersion(3, 2);

+   public static final ProtocolVersion SSL_2 = new ProtocolVersion(0, 2);


    private final int major;
    private final int minor;

***************

*** 83,88 ****
--- 84,91 ----

        return TLS_1;
      if (name.equalsIgnoreCase("TLSv1.1"))

        return TLS_1_1;
+     if (name.equalsIgnoreCase ("SSLv2Hello"))
+       return SSL_2;

      throw new IllegalArgumentException ("unknown protocol name: " + name);
    }

On 4/5/07, chinmaya <address@hidden> wrote:

It still breaks with error " unknown protocol name: SSLv2Hello" this in enum ProtocolVersion.
We need a patch in ProtocolVersion too

thanks
chinmaya

java.lang.IllegalArgumentException : unknown protocol name: SSLv2Hello
        at gnu.javax.net.ssl.provider.ProtocolVersion.forName(ProtocolVersion.java:86)
        at gnu.javax.net.ssl.provider.ServerHandshake.chooseProtocol(ServerHandshake.java:176)
        at gnu.javax.net.ssl.provider.ServerHandshake.implHandleInput (ServerHandshake.java:334)
        at gnu.javax.net.ssl.provider.AbstractHandshake.handleInput(AbstractHandshake.java:241)
        at gnu.javax.net.ssl.provider.SSLEngineImpl.unwrap(SSLEngineImpl.java:638)
        at javax.net.ssl.SSLEngine.unwrap(SSLEngine.java:566)
        at gnu.javax.net.ssl.provider.SSLSocketImpl.doHandshake(SSLSocketImpl.java:473)
        at gnu.javax.net.ssl.provider.SSLSocketImpl$SocketInputStream.read( SSLSocketImpl.java :150)
        at org.apache.coyote.http11.InternalInputBuffer.fill(InternalInputBuffer.java:737)
        at org.apache.coyote.http11.InternalInputBuffer.parseRequestLine(InternalInputBuffer.java:398)
        at org.apache.coyote.http11.Http11Processor.process (Http11Processor.java:761)
        at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.processConnection(Http11Protocol.java:705)
        at org.apache.tomcat.util.net.TcpWorkerThread.runIt(PoolTcpEndpoint.java :577)
        at org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:683)
        at java.lang.Thread.run(Thread.java:595)

On 4/4/07, Casey Marshall <address@hidden> wrote:

On Apr 4, 2007, at 11:45 AM, chinmaya wrote:

> Jessie already supports this, and you don't need to specify
> "SSLv2Hello" to enable it. I can add support in Jessie to handle
> SSLv2Hello, to emulate Sun's behavior, but right now it should would
> work as-is.
>
>
> Is there way I could do quick patch myself so that Jessie can
> handle SSLv2Hello?
> If so please instruct me or pass it on to me
>

Can you try the attached patch? If this works for you, I'll commit it
to Classpath.