[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Libcdio-devel] S_ISLNK and S_ISSOCK error in libcdio-0.82
From: |
Rocky Bernstein |
Subject: |
Re: [Libcdio-devel] S_ISLNK and S_ISSOCK error in libcdio-0.82 |
Date: |
Thu, 29 Oct 2009 10:27:11 -0400 |
Thanks for the information and patch. It has been applied and currently in
the git repository. You might want to double check since sometimes I make a
mistake.
The existing tests for S_ISLINK and S_ISSOCK are from a patch supplied by
Mike Frysinger. It was put in, he told me, to support cross compilation. So
I have some concern as to whether this will change that. Anyone care to
comment?
2009/10/29 carlo.bramix <address@hidden>
> Hello,
> the newest version 0.82 cannot be compiled anymore on Mingw.
> The problem happens because the tests for S_ISLNK and S_ISSOCK macros are
> wrong.
> Into configure script it is used AC_COMPILE_IFELSE instead of
> AC_LINK_IFELSE.
> That's a false test because it does not fail even if those macros are
> unsupported.
> Infact the compiler does not generate an error, it just returns a warning
> like "implicit declaration of function S_ISLNK".
> On Mingw 4.4.0 that warning is not even printed, I had to add -Wall to GCC
> options for getting it.
> Attached patch fixes the problem.
> Since the new version has been just released and this bug blocks the
> compilation on all platforms that do not support S_ISLNK and S_ISSOCK, do
> you think it would be possible to release a quick bugfixed revision?
>
> Sincerely,
>
> Carlo Bramini.
>
>