Re: [Libcdio-devel] libcdio 0.83 release around Oct 27

[Rocky Bernstein]

On Thu, Oct 20, 2011 at 8:54 AM, Thomas Schmitt <address@hidden> wrote:

> ...
>
> > Ah. So the problem we are trying to solve is using Sun's C compiler on
> > Solaris 64-bit systems with the largefile support to compile the example
> > programs. In my view somewhat border-case thing to do.
>
>
>
> Independent of the particular operating system, it appears to be a mistake
> to define system macros only after including system headers.
> Since config.h does define such macros, it should be included as first.
>

If you want to suggest a patch to make this work in the environment you
encountered please do.
As long as it keeps the example programs relatively simple, that's fine. I
just don't want to contort these
example programs which are not key to the distribution for what seems to me
to be edge cases.


> ...
>
>
> ---------------------------------------------------------------------
>
> > Run "make test". Or better in my opinion: "remake test". If you use
> "make",
> > GNU make is preferred.
>
> I tried with the unpacked dist tarball and with a copy of my git
> clone from GNU/Linux. Both report the same problems. Detailed test
> output is at the end of this mail.
>
> The following files are present in the tree, but "gmake test" complains
> about them with addresses relative to the root directory.
>  ++ WARN: Can't get file status for /test/data/cdda.cue: No such file or
> directory
>  [...]
>  ++ WARN: could not retrieve file info for `/test/data/p1.nrg': No such
> file or directory
>

> The inability to find a CD drive is due to the lack of a /vold directory.
>  ++ WARN: open (/vol/dev/aliases/cdrom0): No such file or directory
>

Warnings are warnings. Some of the test programs will normally give these
because
it tries various things.

That said, if there are ways to reduce warnings by inserting extra checks I
amenable to that.


> My system adapter libburn/sg-libcdio.c uses this libcdio call to get
> potentially usable drive addresses
>  cdio_get_devices(DRIVER_DEVICE);
> This delivers
>  /dev/rdsk/c2t2d0s2  (SATA DVD burner)
>  /dev/rdsk/c3t0d0s2  (ATAPI DVD ROM drive)
>
> I am riddling about this message:
>  ++ WARN: readdir(/dev/rdsk) failed: No such file or directory
> although i see
>  $ ls -ld /dev/rdsk
>  drwxr-xr-x 195 root sys 195 Jul 27 22:24 /dev/rdsk
>

Dunno why this would be the case or how to remove this. But again warnings
are warnings.


> It did not help to run the test under pfexec (Solaris sudo), which
> i need to perform libisoburn drive tests:
>  $ pfexec gmake test
>  ... same complaints ...
>
>
> > > I also have a real FreeBSD 8 at hand.
> > If you could test with these that'd be fantastic. Many thanks!
>
> Will do next.
>

Many thanks!


>
>
> ---------------------------------------------------------------------
> Test output:
> ---------------------------------------------------------------------
>
> I did in the top directory of the libcdio tree:
>
> $ remake test
> -bash: remake: command not found
>

See  http://bashdb.sourceforge.net/remake .

You'll have to build that from source.

A number of the confusions you've indicated in the past regarding how
to run make (such as the command I had to mention below) could be used to
get the answers.
Specifically it has is a --tasks option which will give you a list of the
"interesting" targets with a description of what
the target does in some cases.


> $ gmake test
> Making check in doc
> gmake[1]: Entering directory
> `/home/thomas/projekte/libcdio_dir/libcdio-0.83git/doc'
> gmake[1]: Nothing to be done for `check'.
> gmake[1]: Leaving directory
> `/home/thomas/projekte/libcdio_dir/libcdio-0.83git/doc'
>
> [... many other "Nothing to be done" ...]
>
> gmake  check-TESTS
> gmake[3]: Entering directory
> `/home/thomas/projekte/libcdio_dir/libcdio-0.83git/test/driver'
> Incorrect: cdda.cue doesn't parse as a CDRWin CUE file.
> Incorrect: isofs-m1.cue doesn't parse as a CDRWin CUE file.
> ++ WARN: Can't get file status for /test/data/cdda.cue:
> No such file or directory
> ++ WARN: could not retrieve file info for `/test/data/cdda.cue': No such
> file or directory
>

Looks like $abs_top_srcdir is not getting set in your Makefile. Running
"remake -x" might indicate why.

++ WARN: can't open nrg image file /test/data/cdda.cue for reading
>

ditto ..

Can't open cdda.cue
> FAIL: bincue
>



> PASS: cdrdao
> SKIP: freebsd
> SKIP: gnu_linux
> ++ WARN: readdir(/dev/rdsk) failed: No such file or directory
>
> ++ WARN: open (/vol/dev/aliases/cdrom0): No such file or directory
> Can't find a CD-ROM drive. Skipping test.
> SKIP: mmc_read
> ++ WARN: readdir(/dev/rdsk) failed: No such file or directory
>
> ++ WARN: open (/vol/dev/aliases/cdrom0): No such file or directory
> Can't find a CD-ROM drive. Skipping test.
> SKIP: mmc_write
> ++ WARN: could not retrieve file info for `/test/data/p1.nrg': No such file
> or directory
> ++ WARN: can't open nrg image file /test/data/p1.nrg for reading
> Can't open Nero image file: /test/data/p1.nrg.
> FAIL: nrg
> SKIP: osx
> Temp directory is /var/tmp/
> PASS: realpath
> ++ WARN: readdir(/dev/rdsk) failed: No such file or directory
>
> ++ WARN: open (/vol/dev/aliases/cdrom0): No such file or directory
> Can't find a CD-ROM drive. Skipping test.
> SKIP: solaris
> SKIP: win32
> =====================================
> 2 of 4 tests failed
> (7 tests were not run)
> Please report to address@hidden
> =====================================
>
> [... some final messages about leaving directories ...]
> $
>
> With Solaris make:
>
> $ make test
> [... same messages followed by shell code quotes from the makefile ...]
> make: Fatal error: Command failed for target `check-recursive'
> $
>
> ---------------------------------------------------------------------
>
>
> Have a nice day :)
>
> Thomas
>
>
>