Re: [Libcdio-devel] Fixed disc eject support on OS X

[Natalia Portillo]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hi all,

I agree on the change.

Regards,
Natalia Portillo

El 14/6/15 a las 19:33, Rocky Bernstein escribió:
> The change was made in the git sources: 
> https://savannah.gnu.org/git/?group=libcdio
> 
> On Sun, Jun 14, 2015 at 1:25 PM, Natalia Portillo
> <address@hidden> wrote:
> 
> Hi all,
> 
> Is it me or there is no patch attached?
> 
> Regards, Natalia Portillo
> 
> El 14/6/15 a las 18:23, Rocky Bernstein escribió:
>>>> I'm not competent enough in OSX to verify what you report. I
>>>> hope others will try out the code, and that someone more
>>>> knowledgeable will weigh in. Silence though will be taken as
>>>> agreement with your change.
>>>> 
>>>> Thanks for digging into this and making the change.
>>>> 
>>>> On Sun, Jun 14, 2015 at 12:23 PM, Robert Kausch 
>>>> <address@hidden> wrote:
>>>> 
>>>>> Hi all,
>>>>> 
>>>>> just had a closer look at the issues I had with ejecting
>>>>> discs using libcdio on OS X.
>>>>> 
>>>>> To eject, we scheduled the DADiskUnmount and DADiskEject
>>>>> commands and then ran
>>>>> CFRunLoopRunInMode(kCFRunLoopDefaultMode, 30.0, TRUE); to
>>>>> execute. This runs the current runloop until a connected
>>>>> source gets signaled or it times out. The catch is that it
>>>>> stops on _any_ connected source getting signaled which
>>>>> works fine for command line applications where usually only
>>>>> our own source (dacontext.canceled) is attached to the
>>>>> runloop. However, in Cocoa applications many other sources
>>>>> may be connected to the same runloop and fire signals all
>>>>> the time. The solution is to run that call in a loop until
>>>>> our source got signaled or it timed out.
>>>>> 
>>>>> Another issue was in using kDADiskUnmountOptionDefault
>>>>> when unmounting. This unmounted only the audio part when
>>>>> dealing with CD-Extra discs; the data session stayed
>>>>> mounted and prevented the disc ejection. I changed it to
>>>>> kDADiskUnmountOptionWhole to remedy.
>>>>> 
>>>>> Robert ---- Robert Kausch address@hidden
>>>>> 
>>>>> 
>> 
>> 
-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - http://gpgtools.org

iF4EAREIAAYFAlV90PwACgkQSCoUxoi1n+uWSwD/cRZJWm1mCD7ffNTtltVQbHg0
IDreWVAELymSEAOAY1cA/2/XRTozj4A9aB5/CnEj0EfKkdVUCHjQk9F0teafx+9J
=CZp9
-----END PGP SIGNATURE-----