[Libcdio-devel] Fwd: [bug #53929] cd-text with invalid characters failing to convert to utf8

[Rocky Bernstein]

If anyone has thoughts - let me/us know.
---------- Forwarded message ---------
From: Serge Pouliquen <address@hidden>
Date: Thu, Apr 25, 2019 at 9:35 AM
Subject: [bug #53929] cd-text with invalid characters failing to convert to
utf8
To: Rocky Bernstein <address@hidden>, Serge Pouliquen <address@hidden>


Follow-up Comment #5, bug #53929 (project libcdio):

Sorry, I probably forgot to add a comment.
(I don't really remember)

I made a run to the branch (serge-cdtext), it is unfixed (to me)

Your code is testing utf8 conversion, and not using any string in case of
error.
My proposition was using the unconverted string in case of error.
Your commit and the previous are producing the same output (with my cd) : no
output

the proposed commit :
http://git.savannah.gnu.org/cgit/libcdio.git/commit/?h=serge-cdtext&id=75c55514e6c7e621874762e14c6d40d648ecf87c

Is the test case blocking ?
because I don't believe I will be able to make a test case (not enough skill
in C language)

> In case of error, the read value from cd wil be used without any
convertion.
In my case, only one character was useless instead of the whole line to be
absent.
Did you find it was a bad idea to use the string without utf8 convertion ?

Did you
Serge

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?53929>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/