Re: [libmicrohttpd] sending with chunked encoding

[Christian Grothoff]

Dear Eivind,

Yes, I think you're right.  That field is pretty much not used and hence the 
code should be removed.  I think the problem was that the 'Connection: Close' 
case cannot be addressed at the time where that check is taking place, and 
hence the (extended, correct) logic was implemented elsewhere later -- and 
since the field is not used it was not easily noticed.

I'm removing the "dead" (or useless) code in SVN HEAD (SVN 14501).  Thanks for 
pointing this out.

Happy hacking,

Christian

On Wednesday 23 February 2011 01:53:16 Eivind Sarto wrote:
> Christian,
> 
> I am looking at the code (0.9.5) for chunked encoding.  When creating a
> callback with MHD_SIZE_UNKNOWN, the library sets
>    connection->have_chunked_response=MHD_YES
> but the state machine never checks this variable.
> 
> It looks like it uses connection->have_chunked_upload to flag that it is
> sending with a chunked encoding. Is that right, or am I just confused?
> 
> -eivind