Re: [libmicrohttpd] Compiler Warnings with 0.9.33

[Christian Grothoff]

I've fixed some of your warnings in SVN HEAD, they were all harmless
though.  Note that I don't fix "unused parameter" warnings as that
just makes the code more cluttered with extra annotations.  Also,
this warning:

On 12/22/2013 02:42 PM, Dilyan Palauzov wrote:
> daemon.c: In function ‘parse_options_va’:
> daemon.c:2850:14: warning: comparison is always false due to limited
> range of data type [-Wtype-limits]
>     if (daemon->worker_pool_size >= (SIZE_MAX / sizeof (struct
> MHD_Daemon)))

MUST not be fixed (by removal) as it is only true that the condition can
never be false on _some platforms_. On other platforms, the check is indeed
important.  One could probably add some "#if"'s around it, but I don't think
that makes the code any better or clearer.

Happy hacking!

Christian