Re: Support -library=stlport4 with Sun C++ compiler

[Peter O'Gorman]

On Aug 3, 2006, at 9:50 PM, Ralf Menzel wrote:

> Hi,
>
> Albert Chin <address@hidden> writes:
> > Good catch. Updated patch attached.
> >
> > 2006-08-01  Albert Chin <address@hidden>
> >
> >         * libtool.m4 (AC_LIBTOOL_POSTDEP_PREDEP) [ solaris ]:
> >         Don't set $postdeps to "-lCstd -lCrun" if
> >         "-library=stlport4" set in CXXFLAGS as stlport4 C++
> >         library incompatible with Cstd C++ library. Use
> >         '-library=Cstd -library=Crun' instead of '-lCstd -lCrun'.
> >
> > 2006-08-01  Albert Chin <address@hidden>
> >
> >         * libltdl/m4/libtool.m4 (_LT_SYS_HIDDEN_LIBDEPS) [ solaris ]:
> >         Don't set $postdeps to "-lCstd -lCrun" if
> >         "-library=stlport4" set in CXXFLAGS as stlport4 C++
> >         library incompatible with Cstd C++ library. Use
> >         '-library=Cstd -library=Crun' instead of '-lCstd -lCrun'.
>
> I found some problems with the patches:
>
> 1. In the patch for libtool-HEAD the 'for ... do' line is superflous.
>
> 2. _LT_AC_TAGVAR doesn't seem to work with libtool-HEAD. I used
>    _LT_TAGVAR, which seems to work.
>
> 3. In libtool-HEAD the patch addresses the Sun C compiler for Linux
>    and not for Solaris, while the patch for libtool-1-5 addresses the
>    Solaris compiler and ignores the linux version.
>
> The following patches seem to work for me:
>
> <libtool-1-5-patch>
> <libtool-HEAD-patch>

Inadequate review. Thanks for pointing it out.

Sorry,
Peter