libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Skip dup convenience deplibs test more robustly


From: Noah Misch
Subject: Skip dup convenience deplibs test more robustly
Date: Fri, 4 May 2007 16:17:06 -0700
User-agent: Mutt/1.5.9i

powerpc-apple-dwarwin5.5 gets an unexpected pass for the duplicate convenience
deplibs test.  Rather than grow the list of xfail exclusions, I changed the test
to skip when the link command that might need a working --preserve-dup-deps
can succeed without it.

The test continues to xfail on GNU/Linux, but it now skips on Mac OS 10.1.  It
should now skip rather than pass on AIX.

2007-05-04  Noah Misch  <address@hidden>

        * tests/duplicate_deps.at: Make the XFAIL unconditional, but skip the
        test if the test link would succeed even without --preserve-dup-deps.

diff -urpX dontdiff lt-echozsh/tests/duplicate_deps.at 
lt-dupdepskip/tests/duplicate_deps.at
--- lt-echozsh/tests/duplicate_deps.at  2007-03-25 07:12:43.000000000 -0500
+++ lt-dupdepskip/tests/duplicate_deps.at       2007-05-04 11:44:35.000000000 
-0400
@@ -60,9 +60,15 @@ AT_CHECK([$LIBTOOL --mode=link --tag=CC 
          [0], [ignore], [ignore])
 LT_AT_EXEC_CHECK([./main])
 
-# This currently fails:
-AT_XFAIL_IF([case $host_os in aix*) false;; *) :;; esac])
+# Forgo the workaround and create a true circular dependency.
 $LIBTOOL --mode=link --tag=CC $CC $CFLAGS $LDFLAGS -o libb.la b1.lo
+# Some systems find all symbols anyway; skip this test on such systems.
+AT_CHECK([$LIBTOOL --mode=link --tag=CC \
+         $CC $CFLAGS $LDFLAGS -o main main.$OBJEXT liba.la libb.la liba.la \
+         && exit 77],
+         [1], [ignore], [ignore])
+# Other systems need special treatment, which currently fails.
+AT_XFAIL_IF([:])
 AT_CHECK([$LIBTOOL --mode=link --preserve-dup-deps --tag=CC \
          $CC $CFLAGS $LDFLAGS -o main main.$OBJEXT liba.la libb.la liba.la],
          [0], [ignore], [ignore])




reply via email to

[Prev in Thread] Current Thread [Next in Thread]