Re: -no_fixup_chains patch

[Ozkan Sezer]

On Wed, Jul 3, 2024 at 6:42 PM Ileana Dumitrescu
<ileanadumitrescu95@gmail.com> wrote:
>
> On 02/07/2024 22:01, Václav Haisman wrote:
> > On 28. 06. 24 0:41, Ozkan Sezer wrote:
> >> [Sorry, I seem to have deleted the mailing list message from my inbox]
> >>
> >> Regarding -no_fixup_chains patch i.e.
> >>
> >> http://git.savannah.gnu.org/gitweb/?p=libtool.git;a=commitdiff;h=3d1baeeef90a6b9e16c545babe833f28dca155a7
> >>
> >> Is '+=' universally supported?? Maybe change to something like the
> >> following??
> >
> > Is there a reason not to use AS_VAR_APPEND?
> > (https://www.gnu.org/software/autoconf/manual/autoconf-2.69/html_node/Polymorphic-Variables.html)
> >
>
> I do not think there is a reason not to, so I generated a patch for it:
>
> diff --git a/m4/libtool.m4 b/m4/libtool.m4
> index e9eef32f..36e5bf4e 100644
> --- a/m4/libtool.m4
> +++ b/m4/libtool.m4
> @@ -1089,10 +1089,9 @@ _LT_EOF
>           10.[[012]],*|,*powerpc*-darwin[[5-8]]*)
>             _lt_dar_allow_undefined='$wl-flat_namespace $wl-undefined
> ${wl}suppress' ;;
>           *)
> +          _lt_dar_allow_undefined='$wl-undefined ${wl}dynamic_lookup'
>             if test yes = "$lt_cv_support_no_fixup_chains"; then
> -            _lt_dar_allow_undefined='$wl-undefined ${wl}dynamic_lookup 
> $wl-no_fixup_chains'
> -          else
> -            _lt_dar_allow_undefined='$wl-undefined ${wl}dynamic_lookup'
> +            AS_VAR_APPEND([_lt_dar_allow_undefined], [' 
> $wl-no_fixup_chains'])
>             fi
>           ;;
>         esac
> --
>
> It should result in:
> allow_undefined_flag="\$wl-undefined \${wl}dynamic_lookup
> \$wl-no_fixup_chains"

Seems to work for me. IMO, it is a bit of an extravaganza, but I have no
strong no feelings against it...

However, if you guys do this: AS_VAR_APPEND requires autoconf 2.64. What
is the minimum required autoconf version for libtool.m4?

--
O.S.