Re: (no subject)

[Han-Wen Nienhuys]

ned Kristof Bastiaensen wrote:
> Hi,
>
> About two months ago I had written an improved version of the
> part-combiner, because the current part-combiner has some serious
> problems.  I had send a patch, which worked for the latest stable
> release, and the version from CVS.  However, after more than a month
> my patch still isn't committed.  I have already asked why
> <http://www.mail-archive.com/address@hidden/msg07555.html>,
> but that message got ignored completely.  The reason I wrote that
> patch is because I _need_ it.  Since I put quite some time in
> designing and implementing the part-combiner, it would seem just a
> matter of politeness to respond.
>
> I have send a bug request for some bugs that were not solved by my
> code.  I haven't got a response about that either.
>
> I'd appriciate an answer for these issues.

Hi,

I'm somewhat reluctant to add the code, since it is a large body of code 
that I don't understand well enough to deal with bugreports. In 
addition, the whole design of the part-combiner will be trashed anyway 
when we have sensible music stream datastructures (see the mail in 
lilypond-devel by Erik S)

My conditions for integrating this patch are

- I will need a copyright disclaimer for the code

- There should be no regressions: ie. if your code should not have bugs 
that the old code did not have.

If you need the code, also consider to add it yourself;  \partcombine is 
defined in ly/music-functions-init.ly , so it should not be hard to 
write a partcombine-init.ly that defines a \myPartcombine and loads a 
my-partcombine.scm file.

--
 Han-Wen Nienhuys - address@hidden - http://www.xs4all.nl/~hanwen