Re: Why not set TextScript.Y-offset in define-grobs.scm?

[Han-Wen Nienhuys]

Joe Neeman schreef:
> On Fri, 2006-10-20 at 12:08 +0200, Han-Wen Nienhuys wrote:
> > Joe Neeman schreef:
> > > As far as I can tell, whenever a TextScript object is created, it is
> > > immediately sent to Side_position_interface::set_axis(Y_AXIS). It seems
> > > that it is better to just set Y-offset and side-axis in
> > > define-grobs.scm. Is there a reason this is not done? Same thing applies
> > > to Script.
> > the reason is that scripts coming from new-fingering-engraver don't 
> > follow this pattern. But in general it shouldn't hurt to have a default.
> > Just test in advance, to see whether it has unexpected side effect.
>
> But new-fingering-engraver calls make_script_from_event, which calls
> Side_position_interface::set_axis(Y_AXIS), so it should still be ok,
> right?
>
> Anyway, here is the patch. output-distance.py doesn't complain about it.

good. please apply.

--

Han-Wen Nienhuys - address@hidden - http://www.xs4all.nl/~hanwen

LilyPond Software Design
 -- Code for Music Notation
http://www.lilypond-design.com