Re: [PATCH] translations: Make "GIT Committish:" lines obsolete

[John Mandereau]

Le samedi 13 janvier 2007 à 14:56 +0100, Jan Nieuwenhuizen a écrit :
> Johannes Schindelin <address@hidden> writes:
> 
> > Use git to determine when the translation last changed instead of
> > relying on the "GIT Committish" line.
> 
> Thanks for helping to solve this silly Git issue.  However, I do not
> understand, how can Git know what original version was translated?

That's not always possible.  If a translator polishes translation of a
page and commit without running check-translation first, he will miss
changes in English pages.  It is worth trying to make translators' life
easier, but this patch isn't a good solution.  I'd prefer a script that
update the committishes in translated pages automatically when a
translator has made sure the translation is synced with the last fetched
remote head. I'll have a look at Werner's old and ignored
check-translation patch, too ;-)


> It is perfectly possible that the translater copies the entire site
> (currently identifying and freezing the original copy by adding Git
> Committish: <> in those files), translates all files, and commits 2
> weeks later.  In the mean time, the original site has seen several
> updates.

Agreed.  This is even very probable, as Git newbies may pull several
times before they understand they should add and commit newly translated
files.

> Using this patch, will the correct diff be shown to the translator to
> help her incorporating the changes made in the mean time?

After a quick test, I say "yes", but only if you do things right from
the beginning with Git, which is seldom true.  Current check-translation
system is slightly more tolerant and reliable IMHO.


-- 
John Mandereau <address@hidden>