lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Stop \lyricmode { \skip 1.*3 } from failing. (issue 13256053)


From: janek . lilypond
Subject: Re: Stop \lyricmode { \skip 1.*3 } from failing. (issue 13256053)
Date: Tue, 24 Sep 2013 22:29:57 +0000


https://codereview.appspot.com/13256053/diff/1/lily/lexer.ll
File lily/lexer.ll (right):

https://codereview.appspot.com/13256053/diff/1/lily/lexer.ll#newcode588
lily/lexer.ll:588: [^|*.=$#{}\"\\ \t\n\r\f0-9][^$#{}\"\\ \t\n\r\f0-9]* {
On 2013/09/24 16:15:39, dak wrote:
On 2013/09/24 07:44:44, janek wrote:
> Hmm. From my point of view, this deserves some comment (but i don't
insist).

I have a problem thinking of a comment that would add any information
that is
not immediately apparent from the pattern.

Suggestions?

Maybe "because of regex greediness, we have to additionally exclude
patterns beginning with |*.= (without this \lyricmode { \skip 1.*3 }
fails)"?

For me the regex itself required a few moments of thinking to
understand.

Janek

https://codereview.appspot.com/13256053/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]