|
| From: | janek . lilypond |
| Subject: | Re: Issue 3917: Add \alternatingTimeSignatures (issue 97110045) |
| Date: | Sat, 10 May 2014 20:49:08 +0000 |
Come comments.
https://codereview.appspot.com/97110045/diff/80001/ly/music-functions-init.ly
File ly/music-functions-init.ly (right):
https://codereview.appspot.com/97110045/diff/80001/ly/music-functions-init.ly#newcode144
ly/music-functions-init.ly:144: #{ \once\override
Staff.TimeSignature.stencil =
Shouldn't this override be at Score level?
https://codereview.appspot.com/97110045/diff/80001/ly/music-functions-init.ly#newcode149
ly/music-functions-init.ly:149: #(map (lambda (x) #{ \markup
\center-column #(map number->string x) #})
This assumes that the user will input lists of 2 elements. What if the
user enters just one number, or more than two, for example
\alternatingTimeSignatures #'((6 1 8)(5)) ? The function should either
handle such input gracefully or emit a warning/error.
https://codereview.appspot.com/97110045/
| [Prev in Thread] | Current Thread | [Next in Thread] |