[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Reposition voiced rests (Issue 3902) (issue 101720045)
From: |
Phil Holmes |
Subject: |
Re: Reposition voiced rests (Issue 3902) (issue 101720045) |
Date: |
Tue, 27 May 2014 15:26:58 +0100 |
----- Original Message -----
From: <address@hidden>
To: <address@hidden>; <address@hidden>;
<address@hidden>; <address@hidden>; <address@hidden>
Cc: <address@hidden>; <address@hidden>
Sent: Tuesday, May 27, 2014 3:12 PM
Subject: Re: Reposition voiced rests (Issue 3902) (issue 101720045)
https://codereview.appspot.com/101720045/diff/1/lily/rest.cc
File lily/rest.cc (right):
https://codereview.appspot.com/101720045/diff/1/lily/rest.cc#newcode138
lily/rest.cc:138:
To be consistent with your change above, shouldn't this be:
return neutral + 2 * dir;
https://codereview.appspot.com/101720045/
Probably. I can't think of a use case where this code would actually be
exercised, so would welcome a suggestion.
--
Phil Holmes
- Reposition voiced rests (Issue 3902) (issue 101720045), PhilEHolmes, 2014/05/27
- Re: Reposition voiced rests (Issue 3902) (issue 101720045), lilyliska, 2014/05/27
- Re: Reposition voiced rests (Issue 3902) (issue 101720045), lemzwerg, 2014/05/27
- Re: Reposition voiced rests (Issue 3902) (issue 101720045), lilyliska, 2014/05/27
- Re: Reposition voiced rests (Issue 3902) (issue 101720045), david . nalesnik, 2014/05/27
- Re: Reposition voiced rests (Issue 3902) (issue 101720045),
Phil Holmes <=
- Re: Reposition voiced rests (Issue 3902) (issue 101720045), david . nalesnik, 2014/05/27
- Re: Reposition voiced rests (Issue 3902) (issue 101720045), k-ohara5a5a, 2014/05/31