Re: Issue 3935: Use (pretty-print) for some IR props. (issue 95710044)

[dak]

https://codereview.appspot.com/95710044/diff/20001/scm/documentation-lib.scm
File scm/documentation-lib.scm (right):

https://codereview.appspot.com/95710044/diff/20001/scm/documentation-lib.scm#newcode112
scm/documentation-lib.scm:112: (or (vector? val) ; vector is an ly-type
On 2014/05/30 09:11:57, Mark Polesky wrote:
> On 2014/05/30 08:38:23, dak wrote:
> > Comment makes no sense.

> Would this pseudocode suffice?
>    ; (ly-type? vector) => #t

That's rubbish.  None of the given types in ly-type? should trigger for
a vector.  And indeed it would appear that the definition of
ly:music-list? is broken and returns #t for anything that is not a list.

Instead of trying to work around obvious bugs when one finds them, they
should be reported and fixed.

I'll do so, but of course your patch will then depend on mine.  I'll try
to fast-track it.

https://codereview.appspot.com/95710044/diff/20001/scm/documentation-lib.scm#newcode138
scm/documentation-lib.scm:138: (lambda (port) (pretty-print val port
#:display? #t))
On 2014/05/30 09:11:57, Mark Polesky wrote:
> On 2014/05/30 08:38:23, dak wrote:
> > Wouldn't #:display? #t show a partial value of "string" as string
without
> > quotes?  The examples in the issue report don't contain strings, so
it's hard
> to
> > guess.

> That's correct, no quotes, hence the added quotes a few lines below:
>    (string-append "\"" str "\"")

But you'd get ("x" y") to print as (x y) then, wouldn't you?
> An example is in the BarLine node, which after processing looks like
this in
> internals.texi:
>    @item @code{glyph} (string):
>    @code{"|"}

https://codereview.appspot.com/95710044/