[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Add \numbered-time-signature markup command (issue 173260043 by addr
From: |
dak |
Subject: |
Re: Add \numbered-time-signature markup command (issue 173260043 by address@hidden) |
Date: |
Wed, 19 Nov 2014 14:14:20 +0000 |
On 2014/11/19 13:05:44, Dan Eble wrote:
The whole c++-to-scheme work is in
https://codereview.appspot.com/177060043/ .
There is some cruft in it that I didn't want to include, but I have
been short
on free time, so I figured I would post it anyway to provide some
context for
this change. Please do not waste your time reviewing it in detail,
but see
* scm/time-signature.scm for the time-signature print procedure
* scm/time-signature-settings.scm for style-specific markup procedures
Then please advise me what is best for the current patch.
1. Go ahead with \numbered-time-signature
2. Remove the markup command and leave a public
make-numbered-time-signature in
its place
3. Other
Thanks.
Not particularly happy with the name. Related functionality in markups
is called \number (for the font) and \fraction (not using the font I
guess, so less related).
I would lean towards just using a strict analogy to the respective music
command, which would give us \compound-meter (after dashification of
CamelCase). It's a bit iffish in that it does not necessarily need to
be a compound meter, but then that's actually the same situation as with
\compoundMeter so I'd rather keep them the same. And if a better name
is found at some point of time, change both in synch.
https://codereview.appspot.com/173260043/