[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Beautify Grob_array and stop using std::vector::data() (issue 264950
From: |
Keith OHara |
Subject: |
Re: Beautify Grob_array and stop using std::vector::data() (issue 264950043 by address@hidden) |
Date: |
Sat, 05 Sep 2015 18:50:28 -0700 |
User-agent: |
Opera Mail/12.16 (Win32) |
On Sat, 05 Sep 2015 17:49:44 -0700, <address@hidden> wrote:
I have simply removed the comments warning about filtering
ordered arrays.
That seems to be correct. Those comments were incorrect.
The filter_map* functions do not, in fact, change the order of the array under
the meaning of 'ordered_'. Pál's comment makes sense.
There is no sorting method in Grob_array so there is no reason to suspect that the member
'ordered_' has anything to do with order under a sorting criterion. Looking at the
commits that touch 'ordered_' it is clear that its meaning was "this array should
stay in its current order" and that removal of elements doesn't count as a change in
order and substituting Grobs inherit the order the Grobs they replace.
- Re: Beautify Grob_array and stop using std::vector::data() (issue 264950043 by address@hidden), benko . pal, 2015/09/02
- Re: Beautify Grob_array and stop using std::vector::data() (issue 264950043 by address@hidden), nine . fierce . ballads, 2015/09/02
- Re: Beautify Grob_array and stop using std::vector::data() (issue 264950043 by address@hidden), dak, 2015/09/03
- Re: Beautify Grob_array and stop using std::vector::data() (issue 264950043 by address@hidden), nine . fierce . ballads, 2015/09/05
- Re: Beautify Grob_array and stop using std::vector::data() (issue 264950043 by address@hidden), nine . fierce . ballads, 2015/09/05
- Re: Beautify Grob_array and stop using std::vector::data() (issue 264950043 by address@hidden), dak, 2015/09/05
- Re: Beautify Grob_array and stop using std::vector::data() (issue 264950043 by address@hidden), k-ohara5a5a, 2015/09/05
- Re: Beautify Grob_array and stop using std::vector::data() (issue 264950043 by address@hidden), nine . fierce . ballads, 2015/09/05
- Re: Beautify Grob_array and stop using std::vector::data() (issue 264950043 by address@hidden), nine . fierce . ballads, 2015/09/05
- Re: Beautify Grob_array and stop using std::vector::data() (issue 264950043 by address@hidden),
Keith OHara <=
- Re: Beautify Grob_array and stop using std::vector::data() (issue 264950043 by address@hidden), dak, 2015/09/06