[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Implement make-bow-stencil, make-tie-stencil for use in markup-comma
From: |
thomasmorley65 |
Subject: |
Re: Implement make-bow-stencil, make-tie-stencil for use in markup-commands undertie and overtie (issue 270640043 by address@hidden) |
Date: |
Wed, 04 Nov 2015 21:27:33 +0000 |
thanks for review
https://codereview.appspot.com/270640043/diff/1/scm/stencil.scm
File scm/stencil.scm (right):
https://codereview.appspot.com/270640043/diff/1/scm/stencil.scm#newcode50
scm/stencil.scm:50: @var{bow-height} determines the heigth of the bow.
On 2015/11/04 00:28:27, simon.albrecht wrote:
…height…
Done.
https://codereview.appspot.com/270640043/diff/1/scm/stencil.scm#newcode54
scm/stencil.scm:54: Both variables are supplied to support independant
usage.
On 2015/11/04 00:28:27, simon.albrecht wrote:
…independent…
Done.
https://codereview.appspot.com/270640043/diff/1/scm/stencil.scm#newcode56
scm/stencil.scm:56: The task is done by calculating a horizontal bow
with appropiate length first,
On 2015/11/04 00:28:27, simon.albrecht wrote:
…appropriate…
Done.
https://codereview.appspot.com/270640043/diff/1/scm/stencil.scm#newcode64
scm/stencil.scm:64: ;;;; (4) calculat control-points for a horizontal
bezier-curce, beginning
On 2015/11/04 00:28:27, simon.albrecht wrote:
…curve…
Done.
https://codereview.appspot.com/270640043/diff/1/scm/stencil.scm#newcode67
scm/stencil.scm:67: ;;;; (6) move rotated conrol-points to match `start'
On 2015/11/04 00:28:27, simon.albrecht wrote:
…control-points… (both preceding lines)
Done.
https://codereview.appspot.com/270640043/diff/1/scm/stencil.scm#newcode101
scm/stencil.scm:101: ;;;; (4) calculate control-points for a horizontal
bezier-curce,
On 2015/11/04 00:28:27, simon.albrecht wrote:
…curve…
Done.
https://codereview.appspot.com/270640043/diff/1/scm/stencil.scm#newcode138
scm/stencil.scm:138: ;;;; (5) rotate conrol-points around '(0 . 0) to
match `stop'
On 2015/11/04 00:28:27, simon.albrecht wrote:
…control-points…
Done.
https://codereview.appspot.com/270640043/diff/1/scm/stencil.scm#newcode148
scm/stencil.scm:148: ;;;; (6) move rotated conrol-points to match
`start'
On 2015/11/04 00:28:27, simon.albrecht wrote:
…same here…
Done.
https://codereview.appspot.com/270640043/
- Implement make-bow-stencil, make-tie-stencil for use in markup-commands undertie and overtie (issue 270640043 by address@hidden), thomasmorley65, 2015/11/03
- Re: Implement make-bow-stencil, make-tie-stencil for use in markup-commands undertie and overtie (issue 270640043 by address@hidden), simon . albrecht, 2015/11/03
- Re: Implement make-bow-stencil, make-tie-stencil for use in markup-commands undertie and overtie (issue 270640043 by address@hidden),
thomasmorley65 <=
- Re: Implement make-bow-stencil, make-tie-stencil for use in markup-commands undertie and overtie (issue 270640043 by address@hidden), dak, 2015/11/08
- Re: Implement make-bow-stencil, make-tie-stencil for use in markup-commands undertie and overtie (issue 270640043 by address@hidden), thomasmorley65, 2015/11/08
- Re: Implement make-bow-stencil, make-tie-stencil for use in markup-commands undertie and overtie (issue 270640043 by address@hidden), dak, 2015/11/08
- Re: Implement make-bow-stencil, make-tie-stencil for use in markup-commands undertie and overtie (issue 270640043 by address@hidden), thomasmorley65, 2015/11/10
- Re: Implement make-bow-stencil, make-tie-stencil for use in markup-commands undertie and overtie (issue 270640043 by address@hidden), dak, 2015/11/10
- Re: Implement make-bow-stencil, make-tie-stencil for use in markup-commands undertie and overtie (issue 270640043 by address@hidden), thomasmorley65, 2015/11/11
- Re: Implement make-bow-stencil, make-tie-stencil for use in markup-commands undertie and overtie (issue 270640043 by address@hidden), dak, 2015/11/12
- Re: Implement make-bow-stencil, make-tie-stencil for use in markup-commands undertie and overtie (issue 270640043 by address@hidden), thomasmorley65, 2015/11/13
- Re: Implement make-bow-stencil, make-tie-stencil for use in markup-commands undertie and overtie (issue 270640043 by address@hidden), dak, 2015/11/13
- Re: Implement make-bow-stencil, make-tie-stencil for use in markup-commands undertie and overtie (issue 270640043 by address@hidden), thomasmorley65, 2015/11/13