Re: Add ly:one-line-auto-height-breaking (issue 284240043 by address@hidden)

[Urs Liska]

Am 18.01.2016 um 16:17 schrieb Paul Morris:
>> On Jan 18, 2016, at 7:43 AM, address@hidden wrote:
>>
>> This is a great enhancement.
> Thanks Urs.
>
>> I commented on one typo, but I saw two issues (I'll add images to the
>> lilypond-devel copy of this message as soon as it pops up):
>>
>> 1)
>> In one file the instrument name was severely truncated
>>
>> 2)
>> In another file with three staves (staff + piano staff) the vertical
>> spacing of the systems is unusably large.
> How do these compare with ly:one-line-breaking ?  (I might try this myself 
> but I don’t have the .ly files you’re using to test.)  The results should be 
> the same for both since there’s nothing in this patch that should affect this 
> kind of spacing.  It should simply produce the same results as 
> ly:one-line-breaking and then set the height of the page to fit.
>
> So I think changing this kind of spacing behavior would be a separate issue 
> that would also apply to ly:one-line-breaking.  (Of course users can always 
> change the spacing settings to get their desired results.)

You're right, both issues are exactly the same when using
ly:one-line-breaking.

So: Except for the tiny nitpick in the docs: LGTM.

>
>> https://codereview.appspot.com/284240043/diff/1/Documentation/notation/spacing.itely
>> File Documentation/notation/spacing.itely (right):
>>
>> https://codereview.appspot.com/284240043/diff/1/Documentation/notation/spacing.itely#newcode895
>> Documentation/notation/spacing.itely:895: @code{ly:one-line-breaking},
>> @code{ly:one-line-auto-height-page-breaking},
>> I think this should read "ly:one-line-auto-height-breaking”
> Yep, good catch, thanks!
>
>
>
> _______________________________________________
> lilypond-devel mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/lilypond-devel