[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: unfoldRepeats can be restricted to certain repeat-types (issue 31889
From: |
thomasmorley65 |
Subject: |
Re: unfoldRepeats can be restricted to certain repeat-types (issue 318890043 by address@hidden) |
Date: |
Sun, 04 Dec 2016 03:46:58 -0800 |
On 2016/12/03 11:33:15, dak wrote:
David Kastrup <mailto:address@hidden> writes:
> As a user interface, that sounds very much desirable. I don't like
> converting symbols to strings, putting stuff on them, and converting
> them back again.
>
> But it's probably the lesser evil.
Actually, use an alist or a hash internally for mapping
tremolo,volta,whatever to a music type even though it looks like
string
manipulation might do the trick.
That way you can also get #f and put out an error instead of creating
an
illegal music type.
And the result is again reasonably efficient.
--
David Kastrup
Done.
Now a hash-table is used.
I don't think an error is needed, a warning should be sufficient.
https://codereview.appspot.com/318890043/
- Re: unfoldRepeats can be restricted to certain repeat-types (issue 318890043 by address@hidden), (continued)
- Re: unfoldRepeats can be restricted to certain repeat-types (issue 318890043 by address@hidden), Simon Albrecht, 2016/12/01
- Re: unfoldRepeats can be restricted to certain repeat-types (issue 318890043 by address@hidden), thomasmorley65, 2016/12/03
- Re: unfoldRepeats can be restricted to certain repeat-types (issue 318890043 by address@hidden), thomasmorley65, 2016/12/03
- Re: unfoldRepeats can be restricted to certain repeat-types (issue 318890043 by address@hidden), thomasmorley65, 2016/12/03
- Re: unfoldRepeats can be restricted to certain repeat-types (issue 318890043 by address@hidden), thomasmorley65, 2016/12/03
- Re: unfoldRepeats can be restricted to certain repeat-types (issue 318890043 by address@hidden), thomasmorley65, 2016/12/03
- Re: unfoldRepeats can be restricted to certain repeat-types (issue 318890043 by address@hidden),
thomasmorley65 <=