[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Automatic LyricExtenders (issue 313240043 by address@hidden)
From: |
tdanielsmusic |
Subject: |
Re: Automatic LyricExtenders (issue 313240043 by address@hidden) |
Date: |
Sun, 25 Dec 2016 02:52:12 -0800 |
LGTM, with the trivial suggestions indicated below to the NR, but I'm
not competent to check the code sections.
The use of "__" has been expunged completely: should we not retain a
brief mention perhaps for use when the user has turned auto extenders
off?
Trevor
https://codereview.appspot.com/313240043/diff/20001/Documentation/notation/vocal.itely
File Documentation/notation/vocal.itely (right):
https://codereview.appspot.com/313240043/diff/20001/Documentation/notation/vocal.itely#newcode639
Documentation/notation/vocal.itely:639: syllable to the last note of the
melisma. Lilypond detects places
The convention we use is two spaces between sentences.
https://codereview.appspot.com/313240043/diff/20001/Documentation/notation/vocal.itely#newcode853
Documentation/notation/vocal.itely:853: to num staffspaces. No lyric
extenders shorter than this will be automatically
@var{num}
https://codereview.appspot.com/313240043/diff/20001/Documentation/notation/vocal.itely#newcode857
Documentation/notation/vocal.itely:857: @code{\earlyExtender #num}
generates a lyric extender that starts num
@var{num}
https://codereview.appspot.com/313240043/diff/20001/Documentation/notation/vocal.itely#newcode860
Documentation/notation/vocal.itely:860: @code{\forceExtender} forces a
lyric extenders where none would be generated
"extender"
https://codereview.appspot.com/313240043/diff/20001/Documentation/notation/vocal.itely#newcode863
Documentation/notation/vocal.itely:863: @code{\forceExtenderTo #num}
forces a lyric extenders of length num
"extender"; @var{num}
https://codereview.appspot.com/313240043/diff/20001/Documentation/notation/vocal.itely#newcode870
Documentation/notation/vocal.itely:870: num staffspaces left from the
normal endpoint.
@var{num}
https://codereview.appspot.com/313240043/diff/20001/Documentation/notation/vocal.itely#newcode1285
Documentation/notation/vocal.itely:1285: \set associatedVoice = "melody"
This \set associatedVoice is also no longer necessary
https://codereview.appspot.com/313240043/diff/20001/Documentation/notation/vocal.itely#newcode1445
Documentation/notation/vocal.itely:1445: @funindex \repeatTie
@funindex \earlyExtender
@cindex extender, early
@funindex \shortenExtender
@cindex extender, shorten
https://codereview.appspot.com/313240043/diff/20001/Documentation/notation/vocal.itely#newcode1497
Documentation/notation/vocal.itely:1497: around the lyrics and
@code{\skip} commands need to be inserted manually, as
Replace \skip command
https://codereview.appspot.com/313240043/
- Automatic LyricExtenders (issue 313240043 by address@hidden), perpeduumimmobile, 2016/12/23
- Re: Automatic LyricExtenders (issue 313240043 by address@hidden),
tdanielsmusic <=
- Re: Automatic LyricExtenders (issue 313240043 by address@hidden), perpeduumimmobile, 2016/12/25
- Re: Automatic LyricExtenders (issue 313240043 by address@hidden), david . nalesnik, 2016/12/25
- Re: Automatic LyricExtenders (issue 313240043 by address@hidden), nine . fierce . ballads, 2016/12/25
- Re: Automatic LyricExtenders (issue 313240043 by address@hidden), perpeduumimmobile, 2016/12/25
- Re: Automatic LyricExtenders (issue 313240043 by address@hidden), pkx166h, 2016/12/26
- Re: Automatic LyricExtenders (issue 313240043 by address@hidden), perpeduumimmobile, 2016/12/26