|
| From: | david . nalesnik |
| Subject: | Re: Automatic LyricExtenders (issue 313240043 by address@hidden) |
| Date: | Sun, 25 Dec 2016 09:25:26 -0800 |
https://codereview.appspot.com/313240043/diff/40001/lily/self-alignment-interface.cc File lily/self-alignment-interface.cc (right): https://codereview.appspot.com/313240043/diff/40001/lily/self-alignment-interface.cc#newcode61 lily/self-alignment-interface.cc:61: return scm_from_double (- ext.linear_combination (scm_to_double (align))); Grobs are recognized by their interfaces not their names. So here you would write !has_interface<Lyric_syllable_interface> (me) (I confess I'm unclear when internal_has_interface is used, though.) https://codereview.appspot.com/313240043/diff/40001/lily/self-alignment-interface.cc#newcode143 lily/self-alignment-interface.cc:143: x -= ext.linear_combination (scm_to_double (self_align)); See above. https://codereview.appspot.com/313240043/diff/40001/lily/self-alignment-interface.cc#newcode152 lily/self-alignment-interface.cc:152: x += he.linear_combination (scm_to_double (par_align)); See above. https://codereview.appspot.com/313240043/diff/40001/scm/music-functions.scm File scm/music-functions.scm (right): https://codereview.appspot.com/313240043/diff/40001/scm/music-functions.scm#newcode733 scm/music-functions.scm:733: (append (ly:music-property event 'articulations) Why not 'ExtenderEvent instead of (quote ExtenderEvent) ? https://codereview.appspot.com/313240043/
| [Prev in Thread] | Current Thread | [Next in Thread] |